lib/commit: Don't copy xattrs for metadata objects
authorColin Walters <walters@verbum.org>
Mon, 24 Sep 2018 17:37:29 +0000 (13:37 -0400)
committerAtomic Bot <atomic-devel@projectatomic.io>
Tue, 25 Sep 2018 14:49:22 +0000 (14:49 +0000)
commitc141fe610b652f383a9c445169d3cc6f28f99bd1
treef7517b2b752b82c61b9af8ba1bac6dd33a7b534d
parentfc357adb7915c80037136b16dc519cf645e33e36
lib/commit: Don't copy xattrs for metadata objects

Copying the xattrs on metadata objects is wrong in general, we
don't "own" them.  Notably this would fail in the situation of
doing a pull from e.g. a `bare-user` source to a destination
that was on a different mount point (so we couldn't hardlink),
and the source had e.g. a `security.selinux` attribute.

Closes: #1734
Closes: #1736
Approved by: jlebon
src/libostree/ostree-repo-commit.c
tests/installed/nondestructive/itest-pull.sh